On Mon, Aug 21, 2017 at 9:31 PM, Danilo Krummrich <danilokrummrich@xxxxxxxxxxxxx> wrote: > +static int __ps2_gpio_write(struct serio *serio, unsigned char val) > +static int ps2_gpio_write(struct serio *serio, unsigned char val) I never like the random use of __prefixes as they have unclear semantics. I would name it something concise. Anyways, that is up to the subsystem maintainer. >From a GPIO point of view: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html