On Tue, Aug 22, 2017 at 03:30:22PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 18 August 2017 14:23:15 EEST Sakari Ailus wrote: > > struct omap3isp.subdevs field and ISP_MAX_SUBDEVS macro are both unused. > > Remove them. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > The field and macro are still used, you only remove them in patch 2/3. You can > squash 1/3 and 2/3 together. Oh, I missed this indeed. I'll squash the patches. > > > --- > > drivers/media/platform/omap3isp/isp.h | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/media/platform/omap3isp/isp.h > > b/drivers/media/platform/omap3isp/isp.h index e528df6efc09..848cd96b67ca > > 100644 > > --- a/drivers/media/platform/omap3isp/isp.h > > +++ b/drivers/media/platform/omap3isp/isp.h > > @@ -220,9 +220,6 @@ struct isp_device { > > > > unsigned int sbl_resources; > > unsigned int subclk_resources; > > - > > -#define ISP_MAX_SUBDEVS 8 > > - struct v4l2_subdev *subdevs[ISP_MAX_SUBDEVS]; > > }; > > > > struct isp_async_subdev { > > > -- > Regards, > > Laurent Pinchart > -- Sakari Ailus e-mail: sakari.ailus@xxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html