On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach <baruch@xxxxxxxxxx> wrote: > Add device-tree binding documentation SFP transceivers. Support for SFP > transceivers has been recently introduced (drivers/net/phy/sfp.c). > > Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx> > --- > > The SFP driver is on net-next. > > Not sure about the rate-select-gpio property name. The SFP+ standard > (not supported yet) uses two signals, RS0 and RS1. RS0 is compatible > with the SFP rate select signal, while RS1 controls the Tx rate. > --- > Documentation/devicetree/bindings/net/sff-sfp.txt | 24 +++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/sff-sfp.txt > > diff --git a/Documentation/devicetree/bindings/net/sff-sfp.txt b/Documentation/devicetree/bindings/net/sff-sfp.txt > new file mode 100644 > index 000000000000..f0c27bc3925e > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/sff-sfp.txt > @@ -0,0 +1,24 @@ > +Small Form Factor (SFF) Committee Small Form-factor Pluggable (SFP) > +Transceiver > + > +Required properties: > + > +- compatible : must be "sff,sfp" Need to document "sff" vendor prefix. Kind of a short name, but I guess it is sufficient. Are there revisions of the standard (not SFP+) or more than one form factor (I don't recall any)? > + > +Optional Properties: > + > +- i2c-bus : phandle of an I2C bus controller for the SFP two wire serial > + interface Why not a child of the i2c bus it is on? IOW, what should this be a child of? > + > +- moddef0-gpio : phandle of the MOD-DEF0 (AKA Mod_ABS) module presence input > + gpio signal mod-def0-gpios? > + > +- los-gpio : phandle of the Receiver Loss of Signal Indication input gpio > + signal > + > +- tx-fault-gpio : phandle of the Module Transmitter Fault input gpio signal > + > +- tx-disable-gpio : phandle of the Transmitter Disable output gpio signal > + > +- rate-select-gpio : phandle of the Rx Signaling Rate Select (AKA RS0) output > + gpio -gpios is the preferred form for all of these. > -- > 2.14.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html