On 21/08/17 11:54, Masahiro Yamada wrote: >>> + /* parent is GIC */ >>> + parent_fwspec.fwnode = domain->parent->fwnode; >>> + parent_fwspec.param_count = 3; >>> + parent_fwspec.param[0] = 0; /* SPI */ >>> + parent_fwspec.param[1] = hwirq; >>> + parent_fwspec.param[2] = IRQ_TYPE_LEVEL_HIGH; /* properly set later */ >> >> Why defer it to later? You already have the right information in "type", >> so you might as well provide it immediately. > > > Because .irq_set_type() will set it up > before the IRQ is really in use. > > > If we look gic_irq_domain_alloc() implementation, > it does not care "type". > > gic_set_type() will manipulate hardware registers. But that's out of the scope of this driver. Whatever the GIC driver does (or doesn't), you should pass it the right information. > Having said that, it shouldn't hurt to set type here. Exactly. Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
