> On Wed, 16 Aug 2017 21:13:12 +0200
> Lorenzo Bianconi <lorenzo.bianconi83@xxxxxxxxx> wrote:
>
>> Separate data-ready configuration parameters for INT1 and INT2 pins in
>> st_sensor_data_ready_irq data structure. That change will be use to
>> properly support LIS2DW12 accel sensor.
>>
>> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxx>
>
> One oddity which was there already that you've kept.
>
> I'd clean it up whilst we are here rather than doubling it ;)
>
> Jonathan
>
>> @@ -336,7 +341,12 @@ static const struct st_sensor_settings st_press_sensors_settings[] = {
>> .mask = 0x04,
>> },
>> .drdy_irq = {
>> - .addr = 0,
>> + .int1 = {
>> + .addr = 0x00,
>> + },
>> + .int2 = {
>> + .addr = 0x00,
>> + },
> This is presumably for a device which doesn't support data ready.
> Why not rely on the default value of 0 and scrap this explicit entry?
>> },
>> .multi_read_bit = true,
>> .bootime = 2,
Right :). Will do in v2.
Regards,
Lorenzo
--
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
