On Tue, Jan 21, 2014 at 7:12 AM, Ezequiel Garcia
<ezequiel.garcia@xxxxxxxxxxxxxxxxxx> wrote:
> +static int orion_wdt_clock_init(struct platform_device *pdev,
> + struct orion_watchdog *dev)
> +{
> + dev->clk = devm_clk_get(&pdev->dev, NULL);
> + if (IS_ERR(dev->clk))
> + return -ENODEV;
Shouldn't it be 'return PTR_ERR(dev->clk)' instead?
> + clk_prepare_enable(dev->clk);
clk_prepare_enable may fail, so better check its return value.
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
