Hi folks,
We have a large influx of new, unmerged, drivers that are now parsing
fwnode endpoints and each one of them is doing this a little bit
differently. The needs are still exactly the same for the graph data
structure is device independent. This is still a non-trivial task and the
majority of the driver implementations are buggy, just buggy in different
ways.
Facilitate parsing endpoints by adding a convenience function for parsing
the endpoints, and make the omap3isp driver use it as an example.
The parser succeeds an essential bugfix in the set.
I plan to include the first patch to a pull request soonish, the second
could go in with the first user.
Open question: should we designate an error code to silently skip endpoints
from driver's parse_endpoint() callback? Would that be useful? An error
code not relevant for parsing endpoints in general (such as EISDIR) could
be chosen, otherwise we're hampering with error codes that can be returned
in general.
since v1:
- The first patch has been merged (it was a bugfix).
- In anticipation that the parsing can take place over several iterations,
take the existing number of async sub-devices into account when
re-allocating an array of async sub-devices.
- Rework the first patch to better anticipate parsing single endpoint at a
time by a driver.
- Add a second patch that adds a function for parsing endpoints one at a
time based on port and endpoint numbers.
Sakari Ailus (2):
v4l: fwnode: Support generic parsing of graph endpoints in a device
v4l: fwnode: Support generic parsing of graph endpoints in a single
port
drivers/media/platform/omap3isp/isp.c | 116 +++++++---------------
drivers/media/platform/omap3isp/isp.h | 3 -
drivers/media/v4l2-core/v4l2-fwnode.c | 176 ++++++++++++++++++++++++++++++++++
include/media/v4l2-async.h | 4 +-
include/media/v4l2-fwnode.h | 16 ++++
5 files changed, 231 insertions(+), 84 deletions(-)
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
