Re: [PATCH v2 3/5] arm64: dts: rockchip: add tsadc node for rk3328 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






在 2017/8/11 14:38, Caesar Wang 写道:
在 2017年08月04日 16:06, Rocky Hao 写道:
add tsadc needed main information for rk3328 SoC.
50000Hz is the max clock rate supported by tsadc module.

Signed-off-by: Rocky Hao <rocky.hao@xxxxxxxxxxxxxx>
---
Change in v2:
- remove gerrit Change-Id

  arch/arm64/boot/dts/rockchip/rk3328.dtsi | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index db4b2708084d..186fb93fdffd 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -308,6 +308,26 @@
          interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
      };
+    tsadc: tsadc@ff250000 {
+        compatible = "rockchip,rk3328-tsadc";
+        reg = <0x0 0xff250000 0x0 0x100>;
+        interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH 0>;
+        rockchip,grf = <&grf>;
+        clocks = <&cru SCLK_TSADC>, <&cru PCLK_TSADC>;
+        clock-names = "tsadc", "apb_pclk";
+        assigned-clocks = <&cru SCLK_TSADC>;
+        assigned-clock-rates = <50000>;
+        resets = <&cru SRST_TSADC>;
+        reset-names = "tsadc-apb";
+        pinctrl-names = "init", "default", "sleep";
+        pinctrl-0 = <&otp_gpio>;
+        pinctrl-1 = <&otp_out>;
+        pinctrl-2 = <&otp_gpio>;
+        #thermal-sensor-cells = <1>;

Only one sensor, so maybe the value should be 0.
Caesar, #thermal-sensor-cells means parameter counts used to match the proper sensor registered. Both 0 and 1 work well.

Case 0, i.e. #thermal-sensor-cells = <0>, it uses the default channel number 0 to match tsadc channal. Case 1, i.e. #thermal-sensor-cells = <1>, it uses the setting "thermal-sensors = <&tsadc 0>;" to match tsadc channal.

Case 1 provides more readable info than case 0. By my understanding, using the default value such as case 0, is not a good coding style.


+        rockchip,hw-tshut-temp = <100000>;
+        status = "disabled";
+    };
+
      saradc: adc@ff280000 {
compatible = "rockchip,rk3328-saradc", "rockchip,rk3399-saradc";
          reg = <0x0 0xff280000 0x0 0x100>;





--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux