On Thu, 2017-08-10 at 21:54 -0500, Rob Herring wrote: > On Tue, Aug 08, 2017 at 01:42:51PM +0800, Chunfeng Yun wrote: > > The mt8173-mtu3.txt actually holds the bindings for all mediatek > > SoCs with usb3 DRD IP, so add a generic compatible and change the > > name to mtu3.txt. > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> > > --- > > .../bindings/usb/{mt8173-mtu3.txt => mtu3.txt} | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mtu3.txt} (95%) > > > > diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mtu3.txt > > similarity index 95% > > rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt > > rename to Documentation/devicetree/bindings/usb/mtu3.txt > > index 1d7c3bc..832741d 100644 > > --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt > > +++ b/Documentation/devicetree/bindings/usb/mtu3.txt > > mediatek,mtu3.txt Ok > > > @@ -1,7 +1,9 @@ > > The device node for Mediatek USB3.0 DRD controller > > > > Required properties: > > - - compatible : should be "mediatek,mt8173-mtu3" > > + - compatible : should be one of > > + "mediatek,mt8173-mtu3" (deprecated, use "mediatek,mtu3" instead), > > NAK. You can add generic compatibles, but you need SoC specific ones in > addition. It's for backward compatibility > > > + "mediatek,mtu3" Is it appropriate if changed to "mediatek,generic-mtu3"? > > - reg : specifies physical base address and size of the registers > > - reg-names: should be "mac" for device IP and "ippc" for IP port control > > - interrupts : interrupt used by the device IP > > @@ -44,7 +46,7 @@ Optional properties: > > Sub-nodes: > > The xhci should be added as subnode to mtu3 as shown in the following example > > if host mode is enabled. The DT binding details of xhci can be found in: > > -Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > +Documentation/devicetree/bindings/usb/xhci-mtk.txt > > This should be in the patch that renames this file. Ok > > > > > Example: > > ssusb: usb@11271000 { > > -- > > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html