On Thu, 03 Aug 2017, Joseph Chen wrote: > From: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx> > > the rk8xx chip id is: > ((MSB << 8) | LSB) & 0xfff0 > > Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx> > Signed-off-by: Joseph Chen <chenjh@xxxxxxxxxxxxxx> > --- > drivers/mfd/rk808.c | 21 +++++++++++++++------ > include/linux/mfd/rk808.h | 1 + > 2 files changed, 16 insertions(+), 6 deletions(-) > > diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c > index fd087cb..3334a2a 100644 > --- a/drivers/mfd/rk808.c > +++ b/drivers/mfd/rk808.c > @@ -325,7 +325,7 @@ static int rk808_probe(struct i2c_client *client, > void (*pm_pwroff_fn)(void); > int nr_pre_init_regs; > int nr_cells; > - int pm_off = 0; > + int pm_off = 0, msb, lsb; > int ret; > int i; > > @@ -333,14 +333,23 @@ static int rk808_probe(struct i2c_client *client, > if (!rk808) > return -ENOMEM; > > - rk808->variant = i2c_smbus_read_word_data(client, RK808_ID_MSB); > - if (rk808->variant < 0) { > - dev_err(&client->dev, "Failed to read the chip id at 0x%02x\n", > + /* read Chip variant */ Nit: This should read "Read chip variant" However, I realise that the rest of the comments do not use correctly formatted English grammar either, so just s/Chip/chip/. Once fixed you can apply my: For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html