On 01/10/2014 04:26 PM, Lee Jones wrote: > On Fri, 10 Jan 2014, Arnd Bergmann wrote: > >> On Friday 10 January 2014, Lee Jones wrote: >>>> >>>> - need_logic_fck = false; >>>> + /* Set all clocks as invalid to begin with */ >>>> + omap->ehci_logic_fck = omap->init_60m_fclk = ERR_PTR(-EINVAL); >>>> + omap->utmi_p1_gfclk = omap->utmi_p2_gfclk = ERR_PTR(-EINVAL); >>>> + omap->xclk60mhsp1_ck = omap->xclk60mhsp2_ck = ERR_PTR(-EINVAL); >>> >>> I don't think this is the correct error code. >>> >>> -EINVAL means 'invalid parameter'. >>> >>> You probably want -ENODEV or -ENOSYS ('function not implemented' >>> probably isn't ideal either tbh, but you get the idea). Perhaps you >>> can set them as NULL and check for IS_ERR_OR_NULL() instead? >> >> I think ENODEV is ok here, I'd much prefer this over IS_ERR_OR_NULL(). > > Sounds good to me. > OK. Will fix. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html