On Thu 03 Aug 10:40 PDT 2017, Rob Herring wrote:
> On Wed, Aug 2, 2017 at 9:57 PM, Bjorn Andersson
> <bjorn.andersson@xxxxxxxxxx> wrote:
> > diff --git a/drivers/of/platform.c b/drivers/of/platform.c
[..]
> > + rmem_nodes = of_find_node_by_path("/reserved-memory");
> > + for_each_available_child_of_node(rmem_nodes, node) {
> > + ret = of_device_compatible_match(node, rmem_compats);
> > + if (ret)
>
> I would just do:
>
> for_each_matching_node(node, ...)
> of_platform_device_create(node, NULL, NULL);
>
> I don't think the kernel has to validate that ramoops and any others
> we add are children of /reserved-memory. We should only have those
> compatibles located there and any other location would be an error.
>
Okay, looks reasonable.
Will update and resend once I know your decision on 2/5.
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
