Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Shawn,

Thus wrote Shawn Guo (shawnguo@xxxxxxxxxx):

> On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> > the addresses used by tscadc and those in its child nodes (adc, tsc).

> > Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> > drivers will then fail since there's no IORESOURCE_MEM.

> > Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>

> Do we need the following Fixes tag?

> Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")

yes, looks like this has never worked correctly.

If you're ok with the fix, I can add the tag in v2.

> @Markus, we didn't the changes when we were submitting?

Both Markus' and Denis' mail addresses bounced...

Best regards,
Martin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux