On Fri, Jul 21, 2017 at 1:19 PM, Joseph Chen <chenjh@xxxxxxxxxxxxxx> wrote: (...) > +Following are optional properties defined as pinmux DT binding document > +<pinctrl-bindings.txt>. Absence of properties will leave the configuration > +on default. > + function, > + output-low, > + output-high. > + > +Valid values for function properties are: gpio. > + > +Theres is also not customised properties for any GPIO. > + > +Example: > +-------- > +rk805: rk805@18 { > + compatible = "rockchip,rk805"; > + ... > + gpio-controller; > + #gpio-cells = <2>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pmic_int_l>, <&rk805_default>; > + > + rk805_default: pinmux { > + gpio01 { > + pins = "gpio0", "gpio1"; > + function = "gpio"; > + output-high. That should be a semicolon. With that fixed: Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html