Hello, Hans.
On Sun, Jan 19, 2014 at 12:48:43AM +0100, Hans de Goede wrote:
> void ahci_start_engine(struct ata_port *ap)
> {
> void __iomem *port_mmio = ahci_port_base(ap);
> + struct ahci_host_priv *hpriv = ap->host->private_data;
> u32 tmp;
>
> + if (hpriv->start_engine) {
> + hpriv->start_engine(ap);
> + return;
> + }
> +
I'd much prefer if the driver always calls hpriv->start_engine() which
is initialized to the default callback during common init and then
overridden if necessary.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
