On Sat, Jul 29, 2017 at 10:17 PM, David Lechner <david@xxxxxxxxxxxxxx> wrote: > This adds a parameter for MIPI DCS pixel format to mipi_dbi_init(). > This is in preparation for supporting displays that don't use a 16bpp > memory layout. > /* MIPI DCS pixel formats */ > -#define MIPI_DCS_PIXEL_FMT_24BIT 7 > -#define MIPI_DCS_PIXEL_FMT_18BIT 6 > -#define MIPI_DCS_PIXEL_FMT_16BIT 5 > -#define MIPI_DCS_PIXEL_FMT_12BIT 3 > -#define MIPI_DCS_PIXEL_FMT_8BIT 2 > -#define MIPI_DCS_PIXEL_FMT_3BIT 1 > +enum mipi_dcs_pixel_format { > + MIPI_DCS_PIXEL_FMT_24BIT = 7, > + MIPI_DCS_PIXEL_FMT_18BIT = 6, > + MIPI_DCS_PIXEL_FMT_16BIT = 5, > + MIPI_DCS_PIXEL_FMT_12BIT = 3, > + MIPI_DCS_PIXEL_FMT_8BIT = 2, > + MIPI_DCS_PIXEL_FMT_3BIT = 1, > +}; May I ask what prevents us to arrange enums in natural ordering (you may keep = X parts, of course)? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html