Re: [PATCH 3/4] ASoC: tlv320aic32x4: DT support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, Jan 16, 2014 at 04:30:26PM +0100, Markus Pargmann wrote:

> +Optional properties:
> + - ti,ldo-enable: Bool, has to be set when the codec is powered only through the
> +   LDOIN pin.

This seems very odd.  Should the regulator bindings not be being used
for this, either having a regulator in the device that's bound via the
DT or using regulator_get_optional() to check for the other supplies
that might be used being provided?

> + - gpio-reset - gpio pin number used for codec reset

This should be a standard GPIO specifier.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux