Hi Fabio, On Mon, Jul 24, 2017 at 2:49 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote: > > Hi Gary, > > On Mon, Jul 24, 2017 at 5:50 AM, Gary Bisson > <gary.bisson@xxxxxxxxxxxxxxxxxxx> wrote: > > > + > > + reg_usb_h1_vbus: regulator@7 { > > + compatible = "regulator-fixed"; > > + reg = <7>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usbh1>; > > + regulator-name = "usb_h1_vbus"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + regulator-always-on; > > As this regulator is controlled via GPIO I believe you should remove > the ' regulator-always-on' property. > > Same applies to 2/2/ Good catch, I'll send a v2 right away. Thanks, Gary -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html