On Mon, 17 Jul 2017 19:39:01 +0200
Lorenzo Bianconi <lorenzo.bianconi83@xxxxxxxxx> wrote:
> Add support for active low interrupts (IRQF_TRIGGER_LOW and
> IRQF_TRIGGER_FALLING). Configure the device as active high or low
> according to the requested irq line.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxx>
Applied
> ---
> drivers/iio/humidity/hts221.h | 1 +
> drivers/iio/humidity/hts221_buffer.c | 11 +++++++++++
> drivers/iio/humidity/hts221_core.c | 3 +--
> 3 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/humidity/hts221.h b/drivers/iio/humidity/hts221.h
> index 69dfa5c63ec2..c3de6e494f8c 100644
> --- a/drivers/iio/humidity/hts221.h
> +++ b/drivers/iio/humidity/hts221.h
> @@ -61,6 +61,7 @@ struct hts221_hw {
> extern const struct dev_pm_ops hts221_pm_ops;
>
> int hts221_config_drdy(struct hts221_hw *hw, bool enable);
> +int hts221_write_with_mask(struct hts221_hw *hw, u8 addr, u8 mask, u8 val);
> int hts221_probe(struct iio_dev *iio_dev);
> int hts221_set_enable(struct hts221_hw *hw, bool enable);
> int hts221_allocate_buffers(struct hts221_hw *hw);
> diff --git a/drivers/iio/humidity/hts221_buffer.c b/drivers/iio/humidity/hts221_buffer.c
> index c4ed153ad397..ad5222295b2c 100644
> --- a/drivers/iio/humidity/hts221_buffer.c
> +++ b/drivers/iio/humidity/hts221_buffer.c
> @@ -22,6 +22,8 @@
>
> #include "hts221.h"
>
> +#define HTS221_REG_DRDY_HL_ADDR 0x22
> +#define HTS221_REG_DRDY_HL_MASK BIT(7)
> #define HTS221_REG_STATUS_ADDR 0x27
> #define HTS221_RH_DRDY_MASK BIT(1)
> #define HTS221_TEMP_DRDY_MASK BIT(0)
> @@ -67,6 +69,7 @@ static irqreturn_t hts221_trigger_handler_thread(int irq, void *private)
> int hts221_allocate_trigger(struct hts221_hw *hw)
> {
> struct iio_dev *iio_dev = iio_priv_to_dev(hw);
> + bool irq_active_low = false;
> unsigned long irq_type;
> int err;
>
> @@ -76,6 +79,10 @@ int hts221_allocate_trigger(struct hts221_hw *hw)
> case IRQF_TRIGGER_HIGH:
> case IRQF_TRIGGER_RISING:
> break;
> + case IRQF_TRIGGER_LOW:
> + case IRQF_TRIGGER_FALLING:
> + irq_active_low = true;
> + break;
> default:
> dev_info(hw->dev,
> "mode %lx unsupported, using IRQF_TRIGGER_RISING\n",
> @@ -84,6 +91,10 @@ int hts221_allocate_trigger(struct hts221_hw *hw)
> break;
> }
>
> + err = hts221_write_with_mask(hw, HTS221_REG_DRDY_HL_ADDR,
> + HTS221_REG_DRDY_HL_MASK, irq_active_low);
> + if (err < 0)
> + return err;
> err = devm_request_threaded_irq(hw->dev, hw->irq, NULL,
> hts221_trigger_handler_thread,
> irq_type | IRQF_ONESHOT,
> diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c
> index dc55d9fbc702..25fcb9993998 100644
> --- a/drivers/iio/humidity/hts221_core.c
> +++ b/drivers/iio/humidity/hts221_core.c
> @@ -135,8 +135,7 @@ static const struct iio_chan_spec hts221_channels[] = {
> IIO_CHAN_SOFT_TIMESTAMP(2),
> };
>
> -static int hts221_write_with_mask(struct hts221_hw *hw, u8 addr, u8 mask,
> - u8 val)
> +int hts221_write_with_mask(struct hts221_hw *hw, u8 addr, u8 mask, u8 val)
> {
> u8 data;
> int err;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
