Re: [PATCH] ARC: reset: introduce HSDKv1 reset driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Eugeniy,

On Wed, 2017-07-19 at 15:32 +0000, Eugeniy Paltsev wrote:
> Hi Philipp,
> 
> On Wed, 2017-07-19 at 17:07 +0200, Philipp Zabel wrote:
> > On Tue, 2017-07-18 at 20:25 +0300, Eugeniy Paltsev wrote:
> > > The HSDK v1 periphery IPs can be reset by accessing some registers
> > > from the CGU block.
> > > 
> > > The list of available reset lines is documented in the DT bindings.
> > > 
> > > [snip]
> > > --- a/drivers/reset/Kconfig
> > > +++ b/drivers/reset/Kconfig
> > > @@ -34,6 +34,12 @@ config RESET_BERLIN
> > >  	help
> > >  	  This enables the reset controller driver for Marvell
> > > Berlin SoCs.
> > >  
> > > +config RESET_HSDK_V1
> > > +	bool "HSDK v1 Reset Driver"
> > > +	default n
> > 
> > I suppose there will be a SOC_HSDK_V1 or similar in the future so
> > that
> > we can hide this option and enable it by default like the other reset
> > drivers?
> Actually we don't have (and don't planning to add) such SOC/board-
> specific kconfig option, so I am wondering if it is OK to just left
> this option not hidden?

Not a problem, I just prefer to enable reset controllers by default when
building kernels for SoCs that may need them. Sometimes they are even
necessary to boot the system. In those cases, allowing to disable the
reset controller driver at all is not very helpful.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux