On Wed, Jul 19, 2017 at 1:22 AM, Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> On Tue, Jul 18, 2017 at 04:42:41PM -0500, Rob Herring wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>
> Oh nice. If the commit adding %pOF is already set in stone, i'd suggest
> to mention the commit id here in the commit log.
It is in 4.13, but I'm not really eager to update all 60 patches and
I'd prefer consistency in the commit msg as quite a few have already
been applied.
>> of the full path string for each node.
[...]
>> @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)
>> */
>> cell = of_get_property(cpu, "reg", &prop_bytes);
>> if (!cell || prop_bytes < sizeof(*cell)) {
>> - pr_debug(" * %s missing reg property\n",
>> - cpu->full_name);
>> + pr_debug(" * %pOF missing reg property\n",
>> + cpu);
>
> You could join lines here and in the next hunk. And there are two more
> further down.
Okay. I did that generally, but missed a few.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
