Re: [PATCH v3 1/3] of: overlay: add overlay unittest data for node names and symbols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Jul 18, 2017 at 10:52 PM,  <frowand.list@xxxxxxxxx> wrote:
> From: Frank Rowand <frank.rowand@xxxxxxxx>
>
> Add nodes and properties to overlay_base and overlay dts files to
> test for
>    - incorrect existing node name detection when overlay node name
>      has a unit-address
>    - adding overlay __symbols__ properties to live tree when an
>      overlay is added to the live tree
>
> The following console messages will appear near the end of unittest
> until the code errors are corrected:
>
>    OF: Duplicate name in fairway-1, renamed to "ride@100#1"
>
>    ### dt-test ### FAIL of_unittest_overlay_high_level():2296 Adding overlay 'overlay_bad_symbol' failed
>
>    ### dt-test ### end of unittest - 190 passed, 1 failed
>
> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>
> ---

> diff --git a/drivers/of/unittest-data/overlay.dts b/drivers/of/unittest-data/overlay.dts
> index 6cd7e6a0c13e..81140adbe770 100644
> --- a/drivers/of/unittest-data/overlay.dts
> +++ b/drivers/of/unittest-data/overlay.dts
> @@ -25,7 +25,18 @@
>                         #size-cells = <1>;
>                         status = "ok";
>
> -                       ride@200 {
> +                       ride@100 {
> +
> +                               track@3 {

These need a reg property.

> +                                       incline_up = < 48 32 16 >;

Don't use '_'.

Build with W=2 to check dtc warnings.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux