Re: [PATCHv3 2/2] spi: imx: document use of native chip-selects in devicetree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello Greg,

On 07/11/2017 07:22 AM, Greg Ungerer wrote:
> Document the "<0>" notation for specifying use of a native chip-select
> in the "cs-gpios" tag of an SPI device in devicetree. This isn't unique
> to the spi-imx driver, but this clearly spells out that you can use it
> with this driver.
> 
> Signed-off-by: Greg Ungerer <gerg@xxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> index 31b5b21..cf616ea 100644
> --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> @@ -12,6 +12,7 @@ Required properties:
>  - reg : Offset and length of the register set for the device
>  - interrupts : Should contain CSPI/eCSPI interrupt
>  - cs-gpios : Specifies the gpio pins to be used for chipselects.
> +	Specify use of native chipselects with "<0>" in place of a gpio.
>  - clocks : Clock specifiers for both ipg and per clocks.
>  - clock-names : Clock names should include both "ipg" and "per"
>  See the clock consumer binding,
> @@ -38,7 +39,8 @@ ecspi@70010000 {
>  	reg = <0x70010000 0x4000>;
>  	interrupts = <36>;
>  	cs-gpios = <&gpio3 24 0>, /* GPIO3_24 */
> -		   <&gpio3 25 0>; /* GPIO3_25 */
> +		   <&gpio3 25 0>, /* GPIO3_25 */
> +		   <0>;           /* Native chip select */
>  	dmas = <&sdma 3 7 1>, <&sdma 4 7 2>;
>  	dma-names = "rx", "tx";
>  	fsl,spi-rdy-drctl = <1>;
> 

Adding Rob to Cc.

Reviewed-by: Vladimir Zapolskiy <vz@xxxxxxxxx>

Rob, if you find the change acceptable, can you ack it?

--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux