On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.wang@xxxxxxxxxxxx wrote:
> + if (!info->modeset_mask) {
> + dev_err(&rdev->dev, "regulator %s doesn't support set_mode\n",
> + info->desc.name);
> + return -EINVAL;
> + }
This is mostly fine but the mode operations all have this code - if the
regulator doesn't have modesetting facilities it just shouldn't have
the ops so the core can handle things in a standard fashion. It'd mean
defining a separate set of operations for those regulators but that's
fine.
Attachment:
signature.asc
Description: PGP signature
