Hi Jon, > This also will need to be added to > drivers/net/ethernet/broadcom/bgmac-bcma.c. Otherwise, the driver > will no longer work for those platforms. Since this was already > accepted, please push out a fix ASAP. > I do not see how the bcma driver [bgmac-bcma.c] will no longer work. The whole idea behind introducing this BGMAC_FEAT_IDM_MASK bit was to keep bcma driver's functionality intact. The BGMAC_FEAT_IDM_MASK bit is explicitly set by the bgmac-platform driver and is unset inside the same if the idm register base is provided. For BCMA driver case, I do not touch BGMAC_FEAT_IDM_MASK bit, i.e. it is *not* set. And if it is not set, each idm operation done in bgmac.c will take place. Please explain if I am missing something here. Regards, Abhishek -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
