On Thursday 16 January 2014 09:47:11 Matthew Garrett wrote: > + if (!of_property_read_u32(np, "phy-mii-advertise-10half", > + &tmp)) { > + if (tmp) { > + *val |= ADVERTISE_10HALF; > + phydev->advertising |= SUPPORTED_10baseT_Half; > + } else { > + phydev->advertising &= > + ~(SUPPORTED_10baseT_Half); > + } > + > + *mask |= ADVERTISE_10HALF; > + } > + if (!of_property_read_u32(np, "phy-mii-advertise-10full", > + &tmp)) { > + if (tmp) { > + *val |= ADVERTISE_10FULL; > + phydev->advertising |= SUPPORTED_10baseT_Full; > + } else { > + phydev->advertising &= > + ~(SUPPORTED_10baseT_Full); > + } > + > + *mask |= ADVERTISE_10FULL; > + } > Just a style suggestion: rather than almost duplicating the same 12 lines of code for each property, I think it can be split out into a helper function. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html