Hi, Mark Rutland wrote: > On Mon, Jan 13, 2014 at 10:17:04AM +0000, Lothar Waßmann wrote: > > This patch allows the edt-ft5x06 multitouch panel driver to be > > configured via DT. > > > > Signed-off-by: Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx> > > --- > > .../bindings/input/touchscreen/edt-ft5x06.txt | 31 ++++ > > drivers/input/touchscreen/edt-ft5x06.c | 145 +++++++++++++++---- > > 2 files changed, 145 insertions(+), 31 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt > > new file mode 100644 > > index 0000000..629dbdd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt > > @@ -0,0 +1,31 @@ > > +* EDT FT5x06 Multiple Touch Controller > > + [...] > > +- threshold: allows setting the "click"-threshold in the range from 20 to 80. > > +- gain: sensitivity (0..31) (lower value -> higher sensitivity) > > +- offset: edge compensation (0..31) > > +- report_rate: report rate (3..14) > > s/_/-/ on property names please. Also, it may make sense to prefix these > as they're rather generic sounding names. > > Could you elaborate on these a litle please? What units are each of > these in? Why does it make sense to have them in the dt? > I just converted them from being passed via platform_data. I have no idea what they actually control and what units they use. I could not even find a manual where they are documented. Maybe Simon Budig can help out here as the original driver author. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@xxxxxxxxxxxxxxxxxxx ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
