Hi Shawn, Thanks for your comments! > -----Original Message----- > From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx] > Sent: 2017年7月13日 16:18 > To: Z.q. Hou <zhiqiang.hou@xxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; catalin.marinas@xxxxxxx; > will.deacon@xxxxxxx; Prabhakar Kushwaha <prabhakar.kushwaha@xxxxxxx> > Subject: Re: [PATCH 1/3] dts: ls2088a: add pcie support > > On Thu, Jul 06, 2017 at 04:55:28PM +0800, Zhiqiang Hou wrote: > > From: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx> > > > > The physical memory map address and CCSR registers map address are > > different between LS2088A and other LS2080A series SoCs. > > > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx> > > --- > > arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi > > index 5c695c6..7d26531 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi > > @@ -134,6 +134,7 @@ > > }; > > > > &pcie1 { > > + compatible = "fsl,ls2088a-pcie", "snps,dw-pcie"; > > I do not see "fsl,ls2088a-pcie" in either bindings doc or kernel driver. > I submitted the DT node patch and driver code patch separately, see the driver patch: https://patchwork.kernel.org/patch/9827915/ Thanks, Zhiqiang ?韬{.n?????%??檩??w?{.n????z谵{???塄}?财??j:+v??????2??璀??摺?囤??z夸z罐?+?????w棹f