2014/1/15 Hans de Goede <hdegoede@xxxxxxxxxx>: > Currently ehci-platform is only used in combination with devicetree when used > with some Via socs. By extending it to (optionally) get clks and a phy from > devicetree, and enabling / disabling those on power_on / off, it can be used > more generically. Specifically after this commit it can be used for the > ehci controller on Allwinner sunxi SoCs. > > Since ehci-platform is intended to handle any generic enough non pci ehci > device, add a "usb-ehci" compatibility string. > > There already is a usb-ehci device-tree bindings document, update this > with clks and phy bindings info. > > Although actually quite generic so far the via,vt8500 compatibilty string > had its own bindings document. Somehow we even ended up with 2 of them. Since > these provide no extra information over the generic usb-ehci documentation, > this patch removes them. > > The ehci-ppc-of.c driver also claims the usb-ehci compatibility string, > even though it mostly is ibm,usb-ehci-440epx specific. ehci-platform.c is > not needed on ppc platforms, so add a !PPC_OF dependency to it to avoid > 2 drivers claiming the same compatibility string getting build on ppc. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/usb/usb-ehci.txt | 25 +++- > .../devicetree/bindings/usb/via,vt8500-ehci.txt | 15 --- > .../devicetree/bindings/usb/vt8500-ehci.txt | 12 -- > drivers/usb/host/Kconfig | 1 + > drivers/usb/host/ehci-platform.c | 149 +++++++++++++++++---- > 5 files changed, 142 insertions(+), 60 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/via,vt8500-ehci.txt > delete mode 100644 Documentation/devicetree/bindings/usb/vt8500-ehci.txt > > diff --git a/Documentation/devicetree/bindings/usb/usb-ehci.txt b/Documentation/devicetree/bindings/usb/usb-ehci.txt > index fa18612..fad10f3 100644 > --- a/Documentation/devicetree/bindings/usb/usb-ehci.txt > +++ b/Documentation/devicetree/bindings/usb/usb-ehci.txt > @@ -7,13 +7,14 @@ Required properties: > (debug-port or other) can be also specified here, but only after > definition of standard EHCI registers. > - interrupts : one EHCI interrupt should be described here. > -If device registers are implemented in big endian mode, the device > -node should have "big-endian-regs" property. > -If controller implementation operates with big endian descriptors, > -"big-endian-desc" property should be specified. > -If both big endian registers and descriptors are used by the controller > -implementation, "big-endian" property can be specified instead of having > -both "big-endian-regs" and "big-endian-desc". > + > +Optional properties: > + - big-endian-regs : boolean, set this for hcds with big-endian registers > + - big-endian-desc : boolean, set this for hcds with big-endian descriptors > + - big-endian : boolean, for hcds with big-endian-regs + big-endian-desc These properties are specified here in the documentation binding, but they are not handled by the ehci-platform driver, is that intentional? Fairly quickly people will start adopting the ehci-platform driver on DT-aware platforms, so it would be nice to support those 2 (3) properties right away? -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
