On Mon, 10 Jul 2017 21:51:58 -0500 Rob Herring <robh@xxxxxxxxxx> wrote: > On Sun, Jul 09, 2017 at 06:57:03PM +0200, Lorenzo Bianconi wrote: > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxx> > > --- > > Documentation/devicetree/bindings/iio/humidity/hts221.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/humidity/hts221.txt b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > > index fca263e13400..732b83c06c08 100644 > > --- a/Documentation/devicetree/bindings/iio/humidity/hts221.txt > > +++ b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > > @@ -5,6 +5,14 @@ Required properties: > > - reg: i2c address of the sensor / spi cs line > > > > Optional properties: > > +- drive-open-drain: the interrupt/data ready line will be configured > > Needs a vendor prefix and "drdy-open-drain" would be more specific. This is straight out of the pinctrl bindings and has been used in a few other places as well. I can see it should really be more obviously associated with the drdy pin though. A few IIO drivers already use this binding (st sensors and the lsm6dsx). If we are going to decide it's a bad idea we should deprecate those bindings and add whatever we do here as well. Jonathan > > > + as open drain, which is useful if several sensors share the same > > + interrupt line. This is a boolean property. > > + (This binding is taken from pinctrl/pinctrl-bindings.txt) > > + If the requested interrupt is configured as IRQ_TYPE_LEVEL_HIGH or > > + IRQ_TYPE_EDGE_RISING a pull-down resistor is needed to drive the line > > + when it is not active, whereas a pull-up one is needed when interrupt > > + line is configured as IRQ_TYPE_LEVEL_LOW or IRQ_TYPE_EDGE_FALLING. > > - interrupt-parent: should be the phandle for the interrupt controller > > - interrupts: interrupt mapping for IRQ. It should be configured with > > flags IRQ_TYPE_LEVEL_HIGH, IRQ_TYPE_EDGE_RISING, IRQ_TYPE_LEVEL_LOW or > > -- > > 2.13.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe devicetree" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html