On Sun, 9 Jul 2017 18:56:57 +0200
Lorenzo Bianconi <lorenzo.bianconi83@xxxxxxxxx> wrote:
> Enable Block Data Update in hts221_probe() in order to avoid to reconfigure
> it every time the sensor is enabled
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxx>
Well there goes part of my concern about extra writes.
Patch looks good
Jonathan
> ---
> drivers/iio/humidity/hts221_core.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c
> index f5181e4e1eff..9546b0ea6283 100644
> --- a/drivers/iio/humidity/hts221_core.c
> +++ b/drivers/iio/humidity/hts221_core.c
> @@ -202,12 +202,6 @@ static int hts221_update_odr(struct hts221_hw *hw, u8 odr)
> if (i == ARRAY_SIZE(hts221_odr_table))
> return -EINVAL;
>
> - /* enable Block Data Update */
> - err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR,
> - HTS221_BDU_MASK, 1);
> - if (err < 0)
> - return err;
> -
> err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR,
> HTS221_ODR_MASK, hts221_odr_table[i].val);
> if (err < 0)
> @@ -644,6 +638,12 @@ int hts221_probe(struct iio_dev *iio_dev)
> iio_dev->name = HTS221_DEV_NAME;
> iio_dev->info = &hts221_info;
>
> + /* enable Block Data Update */
> + err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR,
> + HTS221_BDU_MASK, 1);
> + if (err < 0)
> + return err;
> +
> /* configure humidity sensor */
> err = hts221_parse_rh_caldata(hw);
> if (err < 0) {
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
