2014/1/15 Mark Rutland <mark.rutland@xxxxxxx>: > On Tue, Jan 14, 2014 at 11:48:51PM +0000, Marc Carino wrote: >> Document the bindings that the Broadcom STB platform needs >> for proper bootup. >> >> Signed-off-by: Marc Carino <marc.ceeeee@xxxxxxxxx> >> Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> >> --- >> .../devicetree/bindings/arm/brcm-brcmstb.txt | 43 ++++++++++++++++++++ >> 1 files changed, 43 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/arm/brcm-brcmstb.txt >> >> diff --git a/Documentation/devicetree/bindings/arm/brcm-brcmstb.txt b/Documentation/devicetree/bindings/arm/brcm-brcmstb.txt >> new file mode 100644 >> index 0000000..5f1aba7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/brcm-brcmstb.txt >> @@ -0,0 +1,43 @@ >> +Broadcom STB platforms Device Tree Bindings >> +------------------------------------------- >> +Boards with Broadcom Brahma15 ARM-based BCM7xxx SoC shall have the following >> +properties. >> + >> +Required root node properties: >> + >> + - compatible = "brcm,brcmstb-<chip_id>"; > > I'd prefer it if variants were listed explicitly (as it makes it far > easier to grep for). Something like: > > - compatible: should contain one of: > * "brcm,brcmsrb-7445" > * "brcm,brcmsrb-7446" For consistency with other Broadcom SoCs in mainline, as well as making it easier to grep for products, I would be inclined to use: compatible = "brcm,bcm7445", with the fallback compatible string "brcm,brcmstb". -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
