On 29.06.2017 16:30, Ludovic Desroches wrote: > On Thu, Jun 29, 2017 at 02:56:03PM +0300, Andy Shevchenko wrote: >> On Thu, Jun 29, 2017 at 2:39 PM, Claudiu Beznea >> <claudiu.beznea@xxxxxxxxxxxxx> wrote: >>> Add support for reading from different offsets of EEPROM. >>> The offset is initialized via device tree. If nothing is >>> given as input the old value, 0x90, is used. In this way >>> the driver could be used as generic driver for different >>> vendor memories by only changing the reading offset via >>> device tree. >> >>> + err = device_property_read_u8(dev, "start-offset", &chip->offset); >> >> This property has to be documented. Sure! In this patch series it was documented in patch 2 from series. Are you talking about documenting it in another place? >> >> Moreover, the name looks too broad (I checked current use of >> "*-offset" type of properties and they either vendor specific, or data >> type specific. >> >> Taking above into consideration mac-offset sounds better to me. Ok, I will use that name. > > I agree, it sounds better to me too. Ok, I will use that name. Thanks, Claudiu > > Regards > > Ludovic > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
