Hi, On 25 June 2017 at 01:10, Rafał Miłecki <zajec5@xxxxxxxxx> wrote: > From: Brian Norris <computersforpeace@xxxxxxxxx> > > Partition parsers can now provide an of_match_table to enable > flash<-->parser matching via device tree. > > This support is currently limited to built-in parsers as it uses > request_module() and friends. This should be sufficient for most cases > though as compiling parsers as modules isn't a common choice. > > Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx> > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> I gave this and Rafał's recent patches a spin and split out bcm63xxpart's imagetag parsing into its own parser as a partition parser assigned to the imagetag partition, then added an of_match_table to bcm63xxpart, and it worked beautifully: [ 1.111302] m25p80 spi1.0: s25fl129p1 (16384 Kbytes) [ 1.117222] bcm63xxpart: Partition 0 is CFE offset 0 and length 10000 [ 1.127313] bcm63xxpart: Partition 1 is nvram offset ff0000 and length 10000 [ 1.134604] bcm63xxpart: Partition 2 is linux offset 10000 and length fe0000 [ 1.141927] 3 bcm63xxpart partitions found on MTD device spi1.0 [ 1.148032] Creating 3 MTD partitions on "spi1.0": [ 1.152945] 0x000000000000-0x000000010000 : "CFE" [ 1.161004] 0x000000ff0000-0x000001000000 : "nvram" [ 1.169777] 0x000000010000-0x000000ff0000 : "linux" [ 1.179489] parser_bcm63xx_imagetag: rootfs: CFE image tag found at 0x0 with version 6, board type 96328avng [ 1.189671] parser_bcm63xx_imagetag: Partition 0 is kernel offset 100 and length 151f52 [ 1.197902] parser_bcm63xx_imagetag: Partition 1 is rootfs offset 152052 and length e8dfae [ 1.206405] parser_bcm63xx_imagetag: Spare partition is offset 350004 and length c8fffc [ 1.214738] 2 bcm63xx-imagetag partitions found on MTD device linux [ 1.221201] Creating 2 MTD partitions on "linux": [ 1.226032] 0x000000000100-0x000000152052 : "kernel" [ 1.234445] 0x000000152052-0x000000fe0000 : "rootfs" Things I did: 1) having just the compatible for bcm63xxpart: bcm63xxpart was used. 2) bcm63xxpart, then fixed-partitions as two compatible strings: bcm63xxpart was used. 3) fixed-partitons, then bcm63xxpart: ofpart was used. 4) non-existent compatible, then fixed-partitons: ofpart was used. then I ran out of ideas to test. I guess this might be enough for a Tested-by: Jonas Gorski <jonas.gorski@xxxxxxxxx> Regards Jonas -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
