Am Samstag, 24. Juni 2017, 04:19:10 CEST schrieb Andrew Lunn: > On Fri, Jun 23, 2017 at 12:41:59PM +0800, David Wu wrote: > > Support internal ephy currently. > > > > Signed-off-by: David Wu <david.wu@xxxxxxxxxxxxxx> > > --- > > drivers/net/phy/Kconfig | 4 ++ > > drivers/net/phy/Makefile | 1 + > > drivers/net/phy/rockchip.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 99 insertions(+) > > create mode 100644 drivers/net/phy/rockchip.c > > > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > > index c360dd6..86010d4 100644 > > --- a/drivers/net/phy/Kconfig > > +++ b/drivers/net/phy/Kconfig > > @@ -350,6 +350,10 @@ config XILINX_GMII2RGMII > > the Reduced Gigabit Media Independent Interface(RGMII) between > > Ethernet physical media devices and the Gigabit Ethernet controller. > > > > +config ROCKCHIP_MAC_PHY > > This is a bit of an odd name, having both MAC and PHY in it. Are there > any other RockChip PHYs? Any external PHYS? Are they register > incompatible with the internal PHY? Is it even RockChip IP? Or has it > been licensed from somebody else? > > I would more likely just call it ROCKCHIP_PHY. hmm, we do have quite a number of non-net phys in the phy subsystem (DP, PCIe, ...) and given that the above would be CONFIG_ROCKCHIP_PHY in a global sense, sounds like it could make things confusing. So some addition sounds reasonable ... ROCKCHIP_ETH_PHY or so? Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
