Hi Hans, On 16-06-2017 14:44, Hans Verkuil wrote: > >>> <snip> >>> >>>> + /* CEC */ >>>> + dw_dev->cec_adap = cec_allocate_adapter(&dw_hdmi_cec_adap_ops, >>>> + dw_dev, dev_name(dev), CEC_CAP_TRANSMIT | >>>> + CEC_CAP_PHYS_ADDR | CEC_CAP_LOG_ADDRS, >>> Add CEC_CAP_RC and CEC_CAP_PASSTHROUGH. >>> >>> I'm not sure about CEC_CAP_PHYS_ADDR. The problem here is that this driver >>> doesn't handle the EDID, but without that it doesn't know what physical >>> address to use. >>> >>> I wonder if the cec-notifier can be used for this, possibly with adaptations. >>> Relying on users to set the physical address is a last resort since it is very >>> painful to do so. cec-notifier was specifically designed to solve this. >> Yes, EDID ROM is not integrated into the controller so I can't >> add the code. How exactly can I use cec-notifier here? > drivers/media/platform/sti/cec/stih-cec.c is a good example. The notifier is > called by drivers/gpu/drm/sti/sti_hdmi.c. Done! Implemented and working :) I'm wondering if you want me to wait some more time for other comments or just send the v3 now? I also added support for SCDC read request (its a matter of activating a bit). BTW, I used the DT node name "hdmi-phandle" but I don't know if it is the best because it can cause confusion about the hdmi-phandle that you documented in media/cec.txt Best regards, Jose Miguel Abreu > > Regards, > > Hans > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
