On Fri, Jun 9, 2017 at 2:50 AM, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > On 06/07/2017 11:13 PM, Rob Herring wrote: >> On Tue, May 30, 2017 at 10:26:33PM +0200, Heiner Kallweit wrote: >>> Add dt binding documentation for Amlogic meson GPIO interrupt controller. >>> >>> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> >>> Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> >>> --- >>> v5: >>> - added Reviewed-by >>> --- >>> .../amlogic,meson-gpio-intc.txt | 26 ++++++++++++++++++++++ >>> 1 file changed, 26 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt >>> >>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt >>> new file mode 100644 >>> index 00000000..2f20d212 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt >>> @@ -0,0 +1,26 @@ >>> +Amlogic meson GPIO interrupt controller >>> + >>> +Meson SoCs contains an interrupt controller which is able watch the SoC pads >>> +and generate an interrupt on edges or level. The controller is essentially a >>> +256 pads to 8 GIC interrupt multiplexer, with a filter block to select edge >>> +or level and polarity. The actual number of interrupt exposed depends on the >>> +SoC. >>> + >>> +Required properties: >>> + >>> +- compatible : should be "amlogic,meson-gpio-intc". >>> +- reg : Specifies base physical address and size of the registers. >>> +- interrupt-controller : Identifies the node as an interrupt controller. >>> +- #interrupt-cells : should be 2. >>> +- parent-interrupts : list of GIC interrupts which can be used with the >>> + GPIO IRQ multiplexer >> >> Just use "interrupts" here. > > Hi Rob, > > If the "interrupts" property is used here like this, it breaks the interrupts binding ! Really!? Looking closer at the series, in fact the dts files are already correct: + gpio_intc: interrupt-controller@9880 { + compatible = "amlogic,meson-gpio-intc"; + reg = <0x9880 0x10>; + interrupt-controller; + #interrupt-cells = <2>; + interrupts = <64 65 66 67 68 79 70 71>; + }; + Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html