On Tue, Jun 6, 2017 at 4:37 AM, Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > The device and fwnode property API supports Devicetree, ACPI and pset > properties. The implementation of this functionality for each firmware > type was embedded in the fwnode property core. Move it out to firmware > type specific locations, making it easier to maintain. > > Depends-on: ("of: Move OF property and graph API from base.c to property.c") > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > --- > drivers/acpi/property.c | 68 ++++++++++++++++ > drivers/acpi/scan.c | 1 + > drivers/base/property.c | 208 +++++++++++++++++++----------------------------- > drivers/of/property.c | 90 +++++++++++++++++++++ > include/linux/acpi.h | 4 + > include/linux/fwnode.h | 54 +++++++++++++ > include/linux/of.h | 2 + > 7 files changed, 302 insertions(+), 125 deletions(-) > > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c > index 9364398..14013f6 100644 > --- a/drivers/acpi/property.c > +++ b/drivers/acpi/property.c > @@ -57,6 +57,7 @@ static bool acpi_nondev_subnode_extract(const union acpi_object *desc, > > dn->name = link->package.elements[0].string.pointer; > dn->fwnode.type = FWNODE_ACPI_DATA; > + dn->fwnode.ops = &acpi_fwnode_ops; Mainly in interest of not growing fwnode_handle, we could remove .type and just have checks like "ops == &acpi_fwnode_ops". Otherwise, for patches 2,3,4: Acked-by: Rob Herring <robh@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html