Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2017-06-09 10:38, Andy Shevchenko wrote:
> On Fri, 2017-06-09 at 07:12 +0200, Peter Rosin wrote:
>> On 2017-06-08 19:36, Luis Oliveira wrote:
>>> @@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
>>>  	}
>>>  
>>>  	i2c_dw_disable_int(dev);
>>> -	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,
>>> irq_flags,
>>> +	ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,
>>> irq_flags,
>>>  			     dev_name(dev->dev), dev);
>>
> 
>> Two extra spaces needed to align with the opening bracket.
> 
> It's a bikeshedding, though it looks like v11 is needed anyway (see
> kbuild bot complains), thus it might be addressed as well.
> 

Bikeshedding or not, checkpatch.pl --strict notifies about the issue
with:

CHECK: Alignment should match open parenthesis

Cheers,
peda
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux