Hello Yamada-san Thank you for your comment. > > Add uniphier-wdt bindings documentation. > > > > Signed-off-by: Keiji Hayashibara <hayashibara.keiji@xxxxxxxxxxxxx> > > > Maybe "dt-bindings: watchdog: ..." for the subject. > > This seems what Rob prefers. > > For example, > https://patchwork.kernel.org/patch/9606365/ OK. I will change the subject in v3 patch. > > > --- > > .../devicetree/bindings/watchdog/uniphier-wdt.txt | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt > > > > diff --git a/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt > b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt > > new file mode 100644 > > index 0000000..a59d1ba > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt > > @@ -0,0 +1,20 @@ > > +UniPhier watchdog timer controller > > + > > +This UniPhier watchdog timer controller must be under sysctrl compatible node. > > Do you mean "syscon compatible" ? The "compatible" word is inappropriate. I will remove it in v3 patch. > > > +Required properties: > > +- compatible: should be "socionext,uniphier-wdt" > > + > > +Example: > > + > > + sysctrl@61840000 { > > + compatible = "socionext,uniphier-ld11-sysctrl", > > + "simple-mfd", "syscon"; > > + reg = <0x61840000 0x4000>; > > + > > + sys_wdt: watchdog { > > + compatible = "socionext,uniphier-wdt"; > > + } > > Could you remove the "sys_dwt: " label? > I'd like the example matched with actual DT files. I will remove it. > > Thanks. > > > > + other nodes ... > > + }; > > -- > > 2.7.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html ---------- Best Regards, Keiji Hayashibara -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
