On Saturday 11 January 2014, Tanmay Inamdar wrote: > On Tue, Jan 7, 2014 at 7:35 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Tuesday 07 January 2014, Tanmay Inamdar wrote: > >> On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > >> > > >> > Better use an anonymous clock? > >> > >> Sorry. Can you please elaborate? > > > > I mean drop the "clock-names" property. > > > Did you mean clock-names in pcie-clock node or pcie node? I can drop > clock-names from pcie clock node. However if I drop clock-names from > pcie node, then clk_get call from pcie host driver would result in > failure. Right? I meant drop it from the pcie node, and change the clk_get call to pass NULL instead of the name, which will get the handle for the only clock provided. You only need clock-names if you have more than one clock in the device node and want to identify them. The pcie-clock node should not have a "clock-names" property at all, unless it has a "clocks" property as well and refers to its clock parent with it. I already noticed in another review that the xgene clocks get this part wrong and that should be fixed for all those clock provides, but it's unrelated to what I was talking about here. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
