Re: [PATCH v3 5/7] docs-rst: media: Sort topic list alphabetically

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Em Tue, 6 Jun 2017 23:57:55 +0300
Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu:

> Hi Mauro,
> 
> Mauro Carvalho Chehab wrote:
> > Em Mon, 10 Apr 2017 16:02:54 +0300
> > Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu:
> >  
> >> Bring some order by alphabetically ordering the list of topics.
> >>
> >> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> >> ---
> >>  Documentation/media/kapi/v4l2-core.rst | 18 +++++++++---------
> >>  1 file changed, 9 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/Documentation/media/kapi/v4l2-core.rst b/Documentation/media/kapi/v4l2-core.rst
> >> index d8f6c46..2fbf532 100644
> >> --- a/Documentation/media/kapi/v4l2-core.rst
> >> +++ b/Documentation/media/kapi/v4l2-core.rst
> >> @@ -4,23 +4,23 @@ Video4Linux devices
> >>  .. toctree::
> >>      :maxdepth: 1
> >>
> >> -    v4l2-intro  
> >
> > NACK.
> >
> > The order of the documentation should match what makes sense for the
> > user that will be reading the docs, and *not* an alphabetical order.  
> 
> I wrote the patch to address some of the review comments I got over the 
> several versions of the patchset. I have no objections to maintaining 
> the current order.

Yeah, developers love putting things in alphabetical order ;)

I remember I had myself the same doubt when I did conversions to ReST :-)
See changeset 58759874002a71cbd48a01b615a210bb474e1f2b: there, everything
but the introduction document (v4l2-framework - on that time) were in
alphabetical order:

+.. toctree::
+    :maxdepth: 1
+
+    v4l2-framework
+    v4l2-async
+    v4l2-controls
+    v4l2-device
+    v4l2-dv-timings
+    v4l2-event
+    v4l2-flash-led-class
+    v4l2-mc
+    v4l2-mediabus
+    v4l2-mem2mem
+    v4l2-of
+    v4l2-rect
+    v4l2-subdev
+    v4l2-tuner
+    v4l2-tveeprom
+    v4l2-videobuf2
+    v4l2-videobuf

However, after reading the documentation, it became clear to me that this
was not a good idea, as the first topic out of v4l2-framework was
V4L2 async framework (with is, IMHO, an "advanced" topic - as not every 
"citizen" needs it). On the other hand, VB/VB2 were the last ones. 
Clearly, VB2 were misplaced, and should come before v4l2-async.

So, the topics were reorganized at changeset f6fa883bb733 to place the
more commonly used categories of functions at the beginning, and the
less used ones at the end.

That's said, the current order may not be perfect. IMHO, we should
some day use multiple TOC trees, adding a description before each
one.

It would also make sense to improve VB2 documentation (currently, it
has only 256 bytes with just include kernel headers), based on what's
written at VB book (with is a real framework description), and move VB
to a legacy section (or remove it, after we get rid of the last driver
using it).

Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux