Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi.

2017-05-23 22:34 GMT+09:00 Javier Martinez Canillas <javier@xxxxxxxxxxxx>:
> The at24 driver allows to register I2C EEPROM chips using different vendor
> and devices, but the I2C subsystem does not take the vendor into account
> when matching using the I2C table since it only has device entries.
>
> But when matching using an OF table, both the vendor and device has to be
> taken into account so the driver defines only a set of compatible strings
> using the "atmel" vendor as a generic fallback for compatible I2C devices.
>
> So add this generic fallback to the device node compatible string to make
> the device to match the driver using the OF device ID table.
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
>
> ---
>
> Changes in v5:
> - Only replace atmel variant but keep other EEPROM vendors (Geert Uytterhoeven).
>
> Changes in v4:
> - Only use the atmel manufacturer in the compatible string instead of
>   keeping the deprecated ones (Rob Herring).
>
> Changes in v3: None
> Changes in v2: None
>
>  arch/arm/boot/dts/uniphier-pro4-ace.dts    | 2 +-
>  arch/arm/boot/dts/uniphier-pro4-sanji.dts  | 2 +-
>  arch/arm/boot/dts/uniphier-pxs2-gentil.dts | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)


Why didn't you touch
arch/arm/boot/dts/uniphier-ref-daughter.dtsi ?



BTW, has the driver change merged?



-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux