On Wed 31 May 09:30 PDT 2017, Stephen Boyd wrote: > On 05/26, Bjorn Andersson wrote: > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > > index ab3093995ded..33013835639d 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > > @@ -241,6 +241,8 @@ > > clocks = <&gcc GCC_CRYPTO_CLK>, <&gcc GCC_CRYPTO_AXI_CLK>, <&gcc GCC_CRYPTO_AHB_CLK>; > > clock-names = "core", "bus", "iface"; > > #reset-cells = <1>; > > + > > + qcom,dload-mode-addr = <0x0 0x193d100>; > > This is TCSR, so why not a phandle to a node? > That makes sense, the region is not mentioned in my documentation and I didn't catch that it's in the middle of &tcsr. I'll update it to reference the existing syscon. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html