Hi! > Thanks for the reviewing. > > For the order, the hardware register mapping has this order (blue/green/red) > from bit0/1/2, I can revert it to (red/green/blue) if there is a strong > concern. I'd do that. > For these two properties: qcom,off-ms/ qcom,on-ms, I am using them to assign > the default blinking on/off time, then the LEDs would have a default > blinking pattern if you do "echo 1 > /sys/class/leds/red/blink" Normally, dts describes hardware; this does not seem to be hardware description, so I'd leave it out. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
