On Wed, May 31, 2017 at 02:52:08PM +0300, Sakari Ailus wrote:
> +static int fwnode_property_read_int_array(
> + struct fwnode_handle *fwnode, const char *propname,
> + unsigned int elem_size, void *val, size_t nval)
You forgot this one :)
> +{
> + int ret;
> +
> + ret = fwnode_call_int_op(fwnode, property_read_int_array, propname,
> + elem_size, val, nval);
> + if (ret == -EINVAL && !IS_ERR_OR_NULL(fwnode) &&
> + !IS_ERR_OR_NULL(fwnode->secondary))
> + ret = fwnode_call_int_op(
> + fwnode->secondary, property_read_int_array, propname,
> + elem_size, val, nval);
> +
> + return ret;
> +}
[...]
> +/**
> + * struct fwnode_operations - Operations for fwnode interface
> + * @get: Get a reference to an fwnode.
> + * @put: Put a reference to an fwnode.
> + * @property_present: Return true if a property is present.
> + * @property_read_integer_array: Read an array of integer properties. Return
> + * zero on success, a negative error code
> + * otherwise.
> + * @property_read_string_array: Read an array of string properties. Return zero
> + * on success, a negative error code otherwise.
> + * @get_parent: Return the parent of an fwnode.
> + * @get_next_child_node: Return the next child node in an iteration.
> + * @get_named_child_node: Return a child node with a given name.
> + */
> +struct fwnode_operations {
> + void (*get)(struct fwnode_handle *fwnode);
> + void (*put)(struct fwnode_handle *fwnode);
> + bool (*property_present)(struct fwnode_handle *fwnode,
> + const char *propname);
> + int (*property_read_int_array)(struct fwnode_handle *fwnode,
> + const char *propname,
> + unsigned int elem_size, void *val,
> + size_t nval);
> + int (*property_read_string_array)(struct fwnode_handle *fwnode_handle,
> + const char *propname,
> + const char **val, size_t nval);
> + struct fwnode_handle *(*get_parent)(struct fwnode_handle *fwnode);
> + struct fwnode_handle *
> + (*get_next_child_node)(struct fwnode_handle *fwnode,
> + struct fwnode_handle *child);
I would do the following instead
struct fwnode_handle *(*get_next_child_node)(struct fwnode_handle *fwnode,
struct fwnode_handle *child);
struct fwnode_handle *(*get_named_child_node)(struct fwnode_handle *fwnode,
const char *name);
Yes, it is over 80 chars but it is more readable this way.
Just saying :) I'll leave this up to you.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
