Hi Mika, Thanks for the review. On 05/31/17 12:44, Mika Westerberg wrote: > On Mon, May 22, 2017 at 11:53:19AM +0300, Sakari Ailus wrote: >> +static int acpi_fwnode_property_read_int_array( > > Yuck! > >> + struct fwnode_handle *fwnode, const char *propname, >> + unsigned int elem_size, void *val, size_t nval) > > Can you please write it like: > > static int acpi_fwnode_property_read_int_array(struct fwnode_handle *fwnode, > const char *propname, unsigned int elem_size, void *val, size_t nval) > > or even > > static int acpi_fwnode_property_read_int_array(struct fwnode_handle *fwnode, > const char *propname, > unsigned int elem_size, > void *val, size_t nval) > > Ditto to all similar constructs in this whole series. Ah. I forgot you didn't like this wrapping and indentation. ;-) That's not uncommon e.g. in V4L2 but many have argued that it's not where you should look for examples. X-) I'll change them. -- Regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
