On Wed, May 24, 2017 at 5:10 AM, A.S. Dong <aisheng.dong@xxxxxxx> wrote: >> > + NOTE: i.MX7ULP PIN_FUNC_ID consists of 4 integers as it shares one >> mux >> > + and config register as follows: >> > + <mux_conf_reg input_reg mux_mode input_val> >> >> As your PIN_FUNC_ID specifies both the pin ids and their mux settings, >> shouldn't you use the newly documented 'pinmux' property in place of >> 'pins'? >> >> Please see >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/ >> ?id=8d5e7c5df0a6c442373628be5221321172b1badf >> >> The current documentation specifies pin ids and mux settings have to be >> assembled in one single integer, which is not your case, but that can be >> changed to make it accept an array of integers values if needed. >> > > Thanks for the info. > Looks good to me. > > Shawn & Linus, > Are you okay with this? > > If yes, I can extend the standard 'pinmux' property to support integer array > and renew the patch series to use it. After reading Jacopo's commit it seems to make a lot of sense indeed, so please do this. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
