On Fri, May 26, 2017 at 3:03 AM, Michael Turquette <mturquette@xxxxxxxxxxxx> wrote: > Hello Anup, > > Quoting Anup Patel (2017-05-22 04:58:19) >> +#include <linux/kernel.h> >> +#include <linux/err.h> >> +#include <linux/clk-provider.h> >> +#include <linux/io.h> >> +#include <linux/of.h> >> +#include <linux/of_address.h> >> +#include <linux/of_device.h> >> +#include <linux/platform_device.h> > > Are all of those headers really needed? Yes, we can reduce the number of headers. I will send revised patchset. > >> +CLK_OF_DECLARE(sr_genpll3_clk, "brcm,sr-genpll3", >> + sr_genpll3_clk_init); > > Why use CLK_OF_DECLARE here? You've got a proper platform driver here. Like Sandeep mentioned previously, we have SP804 timers which require clocks. The sr_genpll3_clk is root clock for SP804 timer clock. Due to this reason we have registered sr_genpll3_clk using CLK_OF_DECLARE() and rest of the clocks via platform driver probe. Regards, Anup -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
