> Lino Sanfilippo <LinoSanfilippo@xxxxxx> hat am 23. Mai 2017 um 20:16 geschrieben:
>
>
> Hi,
>
> On 23.05.2017 15:12, Stefan Wahren wrote:
>
>
> > +}
> > +
> > +static void qca_uart_remove(struct serdev_device *serdev)
> > +{
> > + struct qcauart *qca = serdev_device_get_drvdata(serdev);
> > +
> > + netif_carrier_off(qca->net_dev);
> > + cancel_work_sync(&qca->tx_work);
> > + unregister_netdev(qca->net_dev);
>
> Note that it is still possible that the tx work is queued right after cancel_work_sync()
> returned and before the net device is unregistered (and thus the check for the net device
> being up at the beginning of the tx work function is passed and the function is executed).
Even if the carrier is off? Since i see this pattern in some drivers, can you please point me to a reference like a thread or something else?
> I suggest to avoid this possible race by first unregistering the netdevice and then
> calling cancel_work_sync().
What makes you sure that's safe to unregister the netdev while the tx work queue is possibly active?
> Regards,
> Lino
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
